Metrics in logs - Assembler #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengur
force-pushed
the
assembler_metrics_to_file
branch
3 times, most recently
from
be90f40 to
56d720e
Compare
MayRosenbaum
reviewed
Oct 6, 2025
gengur
force-pushed
the
assembler_metrics_to_file
branch
from
56d720e to
4aa4e3d
Compare
MayRosenbaum
reviewed
Oct 8, 2025
gengur
force-pushed
the
assembler_metrics_to_file
branch
2 times, most recently
from
8612078 to
58e032d
Compare
MayRosenbaum
reviewed
Oct 8, 2025
gengur
force-pushed
the
assembler_metrics_to_file
branch
2 times, most recently
from
7f9b131 to
5065ea1
Compare
MayRosenbaum
reviewed
Oct 8, 2025
gengur
force-pushed
the
assembler_metrics_to_file
branch
4 times, most recently
from
633acae to
5bebcab
Compare
HagarMeir
reviewed
Oct 15, 2025
HagarMeir
reviewed
Oct 15, 2025
gengur
force-pushed
the
assembler_metrics_to_file
branch
from
5bebcab to
e0ef3e2
Compare
gengur
force-pushed
the
assembler_metrics_to_file
branch
2 times, most recently
from
6807b2e to
60cc424
Compare
gengur
force-pushed
the
assembler_metrics_to_file
branch
from
60cc424 to
392db26
Compare
HagarMeir
reviewed
Oct 30, 2025
HagarMeir
reviewed
Oct 30, 2025
HagarMeir
reviewed
Oct 30, 2025
HagarMeir
reviewed
Oct 30, 2025
HagarMeir
reviewed
Oct 30, 2025
gengur
force-pushed
the
assembler_metrics_to_file
branch
from
392db26 to
61f1d7f
Compare
HagarMeir
reviewed
Nov 2, 2025
HagarMeir
reviewed
Nov 2, 2025
gengur
force-pushed
the
assembler_metrics_to_file
branch
3 times, most recently
from
839e81b to
5a1178b
Compare
HagarMeir
force-pushed
the
assembler_metrics_to_file
branch
from
5a1178b to
000c7b2
Compare
tock-ibm
reviewed
Nov 9, 2025
node/ledger/assembler_ledger.go
Outdated
| func (l *AssemblerLedger) GetTxCount() uint64 { | ||
| c := atomic.LoadUint64(&l.transactionCount) | ||
| return c | ||
| func (l *AssemblerLedger) GetBlocksCount() uint64 { |
Contributor
There was a problem hiding this comment.
block count is the height, why do we need another method?
Contributor
Author
There was a problem hiding this comment.
The assembler_role contains the ledger that implements the AssemblerLedgerWrite interface, which does not expose the height.
gengur
force-pushed
the
assembler_metrics_to_file
branch
8 times, most recently
from
c84e482 to
018df9c
Compare
tock-ibm
reviewed
Nov 12, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
node/assembler/assembler_metrics.go
Outdated
| } | ||
|
|
||
| func (m *Metrics) trackMetrics() { | ||
| lastTxCommitted, lastBlocksCommitted := uint64(0), uint64(0) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
node/assembler/assembler_metrics.go
Outdated
| blocksCommitted := atomic.LoadUint64(&m.ledgerMetrics.BlocksCount) | ||
| blocksSizeCommitted := atomic.LoadUint64(&m.ledgerMetrics.BlocksSize) | ||
|
|
||
| m.logger.Infof("ASSEMBLER_METRICS: total committed transactions %d, new transactions in the last %.2f seconds: %d, total blocks: %d, new blocks in the last: %.2f seconds: %d, total size: %d, prefetch buffer size: %d(%s) bytes", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
node/ledger/assembler_ledger.go
Outdated
| return NewAssemblerLedger(logger, ledgerPath) | ||
| } | ||
|
|
||
| type AssemblerLedgerMetrics struct { |
Contributor
There was a problem hiding this comment.
Put it in a new file, it will be the prometheus metrics in the next PR, right?
| return nil, fmt.Errorf("error while fetching last block from ledger %w", err) | ||
| } | ||
| _, _, transactionCount, err = AssemblerBatchIdOrderingInfoAndTxCountFromBlock(block) | ||
| _, _, alm.TransactionCount, err = AssemblerBatchIdOrderingInfoAndTxCountFromBlock(block) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| if err := l.Ledger.Append(configBlock); err != nil { | ||
| panic(err) | ||
| } | ||
| atomic.AddUint64(&l.metrics.BlocksCount, uint64(1)) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| metrics PartitionPrefetchIndexMetrics | ||
| } | ||
|
|
||
| type PartitionPrefetchIndexMetrics [2]*uint64 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
tock-ibm
force-pushed
the
assembler_metrics_to_file
branch
from
018df9c to
10ae0f3
Compare
Signed-off-by: Genady Gurevich <[email protected]>
gengur
force-pushed
the
assembler_metrics_to_file
branch
from
10ae0f3 to
7cde6d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #263